Set stack outputs on migrate #119
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Because `Object.keys(outputs).length < 60` on `lib/util.js#stackHasRoom` always returns true.
|
Can you add a test? I'm surprised why this happens, because all outputs are supposed to be rewritten with their migrated ones: In fact this way seems like it would lose outputs? |
|
stack.Outputs are added by lib/util.js#nestedOutput and called lib/util.js#stackHasRoom before lib/util.js#nestedOutput return Promise.resolve()
.then(() => this.setDeploymentBucketEndpoint())
.then(() => this.migrateExistingResources()) // Call lib/util.js#stackHasRoom
.then(() => this.migrateNewResources()) // Call lib/util.js#stackHasRoom
.then(() => this.replaceReferences()) // Call lib/util.js#nestedOutput
.then(() => this.replaceOutputs()) // Call lib/util.js#nestedOutput
.then(() => this.replaceConditions())
.then(() => this.mergeStackResources())
.then(() => this.sequenceStacks())
.then(() => this.writeNestedStacks())
.then(() => this.logSummary());then stack.Outputs is always |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because
Object.keys(outputs).length < 60onlib/util.js#stackHasRoomalways returns true.